-
Notifications
You must be signed in to change notification settings - Fork 157
breaking: Support Jest 30 (#570) #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* chore(deps): update jest package to v30 * test: update snapshot * ci(gh-action): remove versions of node no longer supported by jest; add modern versions chore(deps): update dependencies for compatibility
Update stylistic ESLint rules to version 5, fixing a BC break. Other dependencies have minor upgrades. This update does *not* include the update to Jest 30.0, because @vue/vue3-jest is not ready for Jest 30.0 yet. See vuejs/vue-jest#573
@lmiller1990 sorry for bothering you. This is the only missing piece that's blocking the Jest v30 update for me. Could you please have a look at the changes and release a new major version? Thank you! |
Hi, sorry for the slow reply. I'm not really working on this repo now (nor have I for quite a while...). I think we need someone to maintain this. If someone is interested, would be great. I am not even sure if I have publish permissions for this anymore, I will have to find out. Re: Jest 30 - it looks like we haven't got any tests running. How did you verify this is even working? |
Hello all, how can we further this release ? |
@@ -14,17 +14,17 @@ | |||
"@babel/core": "^7.9.0", | |||
"@babel/preset-env": "^7.9.0", | |||
"@vue/test-utils": "^1.1.0", | |||
"@vue/vue2-jest": "^29.0.0", | |||
"@vue/vue2-jest": "^30.0.0", | |||
"babel-helper-vue-jsx-merge-props": "^2.0.3", | |||
"babel-plugin-syntax-jsx": "^6.18.0", | |||
"babel-plugin-transform-vue-jsx": "^3.7.0", | |||
"coffeescript": "^2.3.2", | |||
"jade": "^1.11.0", | |||
"jest": "29.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should update this devDependency to 30.x
as well
@lmiller1990 are you still taking care of this PR or does "need someone to maintain" mean you're waiting for someone to take over? Since I'm also blocked by vue-jest not supporting jest v30, I'm definitely willing to help! |
chore(deps): update dependencies for compatibility
fixes #570